Skip to content

ci: add a new test case for the disk is full#3079

Merged
Xuanwo merged 9 commits intoapache:mainfrom
sunheyi6:issue_3062
Oct 13, 2023
Merged

ci: add a new test case for the disk is full#3079
Xuanwo merged 9 commits intoapache:mainfrom
sunheyi6:issue_3062

Conversation

@sunheyi6
Copy link
Copy Markdown
Contributor

@sunheyi6 sunheyi6 commented Sep 15, 2023 •
edited
Loading

Fix #3062

@dqhl76
Copy link
Copy Markdown
Member

dqhl76 commented Sep 15, 2023 •
edited
Loading

I think there might be some misunderstanding here. We need use github action to create a environment that disk is full and test this case in a new crate.

dqhl76
dqhl76 reviewed Sep 15, 2023
View reviewed changes
Comment thread core/tests/fs_write_full_disk/src/main.rs Outdated
@sunheyi6
Copy link
Copy Markdown
Contributor Author

sunheyi6 commented Sep 15, 2023

@dqhl76 cc new changed

Xuanwo
Xuanwo requested changes Sep 16, 2023
View reviewed changes
Comment thread .github/workflows/fs_write_full_disk.yml
@Xuanwo Xuanwo marked this pull request as draft September 18, 2023 12:46
@Zheaoli
Copy link
Copy Markdown
Member

Zheaoli commented Oct 13, 2023 •
edited by suyanhanx
Loading

I think this PR is almost done; just need to update the file header. You can update it when you have time @sunheyi6

@dqhl76 dqhl76 changed the title Add a new test case for the disk is full test: add a new test case for the disk is full Oct 13, 2023
@sunheyi6
Copy link
Copy Markdown
Contributor Author

sunheyi6 commented Oct 13, 2023

I think this PR is almost don; just need to update the file header. You can update it when you have time @sunheyi6

I don't quite understand. Could you please explain it in more detail?

@dqhl76
Copy link
Copy Markdown
Member

dqhl76 commented Oct 13, 2023 •
edited
Loading

I don't quite understand. Could you please explain it in more detail?

We blocked here because file_write_full_disk.rs needs a license header like others

// Licensed to the Apache Software Foundation (ASF) under one....
....

@dqhl76
Copy link
Copy Markdown
Member

dqhl76 commented Oct 13, 2023 •
edited
Loading

Sorry for missing reminding. .github/workflows/fs_write_full_disk.yml also need license header

You can check this for next time https://github.com/apache/incubator-opendal/actions/runs/6505420221/job/17669006210?pr=3079

@dqhl76 dqhl76 marked this pull request as ready for review October 13, 2023 07:47
@Xuanwo Xuanwo changed the title test: add a new test case for the disk is full ci: add a new test case for the disk is full Oct 13, 2023
@github-actions github-actions Bot added the releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" label Oct 13, 2023
Xuanwo
Xuanwo approved these changes Oct 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 6fbdcf2 into apache:main Oct 13, 2023
@sunheyi6 sunheyi6 deleted the issue_3062 branch October 13, 2023 09:11
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dqhl76 dqhl76 dqhl76 left review comments

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

Assignees

No one assigned

Labels

releases-note/ci The PR modifies CI-related content or has a title that begins with "ci"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a new test case for the disk is full

4 participants

@sunheyi6 @dqhl76 @Zheaoli @Xuanwo