Skip to content

refactor(services/webhdfs): Rewrite webhdfs methods signature by using OpXxxx#3109

Merged
Xuanwo merged 4 commits intoapache:mainfrom
cxorm:DAL-3064-WebHDFS
Sep 18, 2023
Merged

refactor(services/webhdfs): Rewrite webhdfs methods signature by using OpXxxx#3109
Xuanwo merged 4 commits intoapache:mainfrom
cxorm:DAL-3064-WebHDFS

Conversation

@cxorm
Copy link
Copy Markdown
Member

@cxorm cxorm commented Sep 18, 2023

This PR addressed the webhdfs part of the issue: #3064

[Note]
I just ran the unit test by cargo test on my local environment.
Please correct me if I missed anything.

@cxorm cxorm requested a review from Xuanwo as a code owner September 18, 2023 06:16
@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Sep 18, 2023
@cxorm
Copy link
Copy Markdown
Member Author

cxorm commented Sep 18, 2023

Rebase main branch to trigger CI.

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM, thanks!

Comment thread core/src/raw/ops.rs Outdated
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 9b4b762 into apache:main Sep 18, 2023
Young-Flash pushed a commit to Young-Flash/opendal that referenced this pull request Sep 19, 2023
…ing `OpXxxx` (apache#3109)

* refactor(service/webHDFS): Passing OpWrite instead of content_type

* refactor(service/webHDFS): Passing OpList instead of start_after

refactor(service/webHDFS): Passing OpList instead of start_after

* use existing API of raw::ops

* format the code snippets of modification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants