Skip to content

test(binding/java): add behavior test framework#3129

Merged
tisonkun merged 26 commits intoapache:mainfrom
G-XD:behavior_test_java
Sep 22, 2023
Merged

test(binding/java): add behavior test framework#3129
tisonkun merged 26 commits intoapache:mainfrom
G-XD:behavior_test_java

Conversation

@G-XD
Copy link
Copy Markdown
Contributor

@G-XD G-XD commented Sep 19, 2023

Related: #3066

Comment thread .github/workflows/service_test_redis.yml
Comment thread bindings/java/.env.example Outdated
Comment thread bindings/java/README.md Outdated
Comment thread bindings/java/src/test/java/org/apache/opendal/services/S3Test.java
Comment thread bindings/java/README.md Outdated
@Xuanwo Xuanwo changed the title test(binding/java): add behavior test framework for java feat(binding/java): add behavior test framework for java Sep 21, 2023
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Sep 21, 2023
@G-XD
Copy link
Copy Markdown
Contributor Author

G-XD commented Sep 21, 2023

Hi, @Xuanwo PTAL

Comment thread .github/workflows/bindings_java.yml Outdated
Comment thread .github/workflows/service_test_redis.yml Outdated
Comment thread bindings/java/src/main/java/org/apache/opendal/Operator.java Outdated
Comment thread bindings/java/src/test/java/org/apache/opendal/OperatorTest.java Outdated
Comment thread bindings/java/src/test/java/org/apache/opendal/OperatorTest.java Outdated
Copy link
Copy Markdown
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we move the redis test in the new framework first instead of making several different things in one PR. This causes a mess for merging.

Comment thread bindings/java/README.md Outdated
Comment thread bindings/java/src/blocking_operator.rs
# Conflicts:
#	bindings/java/src/lib.rs
#	bindings/java/src/main/java/org/apache/opendal/Capability.java
#	bindings/java/src/main/java/org/apache/opendal/Operator.java
#	bindings/java/src/operator.rs
#	bindings/java/src/test/java/org/apache/opendal/AsyncStepsTest.java
#	bindings/java/src/test/java/org/apache/opendal/BlockingOperatorTest.java
#	bindings/java/src/test/java/org/apache/opendal/OperatorInfoTest.java
#	bindings/java/src/test/java/org/apache/opendal/OperatorTest.java
#	bindings/java/src/test/java/org/apache/opendal/RedisServiceTest.java
#	bindings/java/src/test/java/org/apache/opendal/StepsTest.java
Comment thread bindings/java/src/main/java/org/apache/opendal/enums/Schema.java Outdated
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Invite @tisonkun to take another look.

@tisonkun tisonkun self-requested a review September 22, 2023 04:47
Comment thread .github/workflows/bindings_java.yml
Copy link
Copy Markdown
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun merged commit 2160dd6 into apache:main Sep 22, 2023
@tisonkun tisonkun changed the title feat(binding/java): add behavior test framework for java test(binding/java): add behavior test framework Sep 22, 2023
@G-XD
Copy link
Copy Markdown
Contributor Author

G-XD commented Sep 22, 2023

By the way, is it necessary to add tests for presigned related operations?

@G-XD G-XD deleted the behavior_test_java branch October 13, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants