Skip to content

build(bindings/java): support develop with JDK 21 #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisonkun merged 2 commits into from
Sep 20, 2023
Merged

build(bindings/java): support develop with JDK 21 #3140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eae9e20
build(bindings/java): support develop with JDK 21
tisonkun Sep 20, 2023
605b57b
ci: use JDK 21 to verify build
tisonkun Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/bindings_java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,16 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Set up JDK 17
- name: Set up JDK 21
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '17'
distribution: 'zulu'
java-version: '21'
cache: 'maven'
- name: Build and test
- name: Build and check
working-directory: bindings/java
run: ./mvnw spotless:check
run: |
./mvnw clean compile spotless:check

test:
runs-on: ${{ matrix.os }}
Expand Down
10 changes: 7 additions & 3 deletions bindings/java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,19 +52,23 @@
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>

<!-- customized properties -->
<cargo-build.profile>dev</cargo-build.profile>
<cargo-build.features>default</cargo-build.features>
<jni.classifier>${os.detected.classifier}</jni.classifier>

<!-- library dependencies -->
<assertj.version>3.23.1</assertj.version>
<lombok.version>1.18.26</lombok.version>
<lombok.version>1.18.30</lombok.version>
<slf4j.version>2.0.7</slf4j.version>
<testcontainers.version>1.18.3</testcontainers.version>

<!-- plugins dependencies -->
<maven-surefire-plugin.version>3.0.0</maven-surefire-plugin.version>
<exec-maven-plugin.version>3.1.0</exec-maven-plugin.version>
<os-maven-plugin.version>1.7.0</os-maven-plugin.version>
<spotless.version>2.37.0</spotless.version>
<palantir-java-format.version>2.36.0</palantir-java-format.version>
<spotless.version>2.39.0</spotless.version>
</properties>

<dependencyManagement>
Expand Down Expand Up @@ -242,7 +246,7 @@
<configuration>
<java>
<palantirJavaFormat>
<version>2.30.0</version>
<version>${palantir-java-format.version}</version>
</palantirJavaFormat>
<!-- static imports first, then others, no blank lines -->
<importOrder>
Expand Down