feat: Include starting offset for GHAC upload Content-Range#3163
Merged
Xuanwo merged 1 commit intoapache:mainfrom Sep 23, 2023
Merged
feat: Include starting offset for GHAC upload Content-Range#3163Xuanwo merged 1 commit intoapache:mainfrom
Xuanwo merged 1 commit intoapache:mainfrom
Conversation
This adjusts the GitHub Action Cache service to handle multi-part uploads correctly: each upload part needs to specify exactly the range it is for, e.g. to upload an 11 byte file with parts <= 8 bytes, the two requests should set: 1. `Content-Range: bytes 0-8/*` (first 8 bytes) 2. `Content-Range: bytes 9-10/*` (final 3 bytes) Previously, the second request would be `Content-Range: 0-2/*`. This would leave the file not-fully written, and GitHub would reject it with an error. Fixes apache#3162
Contributor
Author
|
There doesn't appear to be automatic tests for GHAC? Let me know if I've missed them. I've tested this in GHA:
|
Xuanwo
changed the title
github-actions
Bot
added
the
releases-note/feat
Member
GHAC requires github secrets which can't be fetched from a forked repository. This is a github issue. You have already done the great work! |
huonw
pushed a commit
to pantsbuild/pants
that referenced
this pull request
Oct 22, 2023
The pull requests apache/opendal#3163 and apache/opendal#3177 have been merged and included in OpenDAL version 0.41. This PR will update OpenDAL to version 0.41, allowing us to rely on tags rather than a specific GitHub commit. Signed-off-by: GitHub <noreply@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts the GitHub Action Cache service to handle multi-part uploads correctly: each upload part needs to specify exactly the range it is for, e.g. to upload an 11 byte file with parts <= 8 bytes, the two requests should set:
Content-Range: bytes 0-8/*(first 8 bytes)Content-Range: bytes 9-10/*(final 3 bytes)Previously, the second request would be
Content-Range: 0-2/*. This would leave the file not-fully written, and GitHub would reject it with an error when committing (close()-ing the writer).Fixes #3162