Skip to content

fix: making OpenDAL compilable on 32hf platforms #3188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 3 commits into from
Sep 26, 2023
Merged

fix: making OpenDAL compilable on 32hf platforms #3188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5238fc
porting: making OpenDAL compilable on 32hf platforms
ClSlaid Sep 26, 2023
9634e9e
patch: merely restrict literals.
ClSlaid Sep 26, 2023
968531d
patch: configure pointer_width on 64bit instead
ClSlaid Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/src/services/cos/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,11 @@ impl Accessor for CosBackend {
// The max multipart size of COS is 5 GiB.
//
// ref: <https://www.tencentcloud.com/document/product/436/14112>
write_multi_max_size: Some(5 * 1024 * 1024 * 1024),
write_multi_max_size: if cfg!(target_pointer_width = "64") {
Some(5 * 1024 * 1024 * 1024)
} else {
Some(usize::MAX)
},

delete: true,
create_dir: true,
Expand Down
6 changes: 5 additions & 1 deletion core/src/services/obs/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,11 @@ impl Accessor for ObsBackend {
// The max multipart size of OBS is 5 GiB.
//
// ref: <https://support.huaweicloud.com/intl/en-us/ugobs-obs/obs_41_0021.html>
write_multi_max_size: Some(5 * 1024 * 1024 * 1024),
write_multi_max_size: if cfg!(target_pointer_width = "64") {
Some(5 * 1024 * 1024 * 1024)
} else {
Some(usize::MAX)
},

delete: true,
create_dir: true,
Expand Down
6 changes: 5 additions & 1 deletion core/src/services/oss/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,11 @@ impl Accessor for OssBackend {
// The max multipart size of OSS is 5 GiB.
//
// ref: <https://www.alibabacloud.com/help/en/oss/user-guide/multipart-upload-12>
write_multi_max_size: Some(5 * 1024 * 1024 * 1024),
write_multi_max_size: if cfg!(target_pointer_width = "64") {
Some(5 * 1024 * 1024 * 1024)
} else {
Some(usize::MAX)
},

delete: true,
create_dir: true,
Expand Down
6 changes: 5 additions & 1 deletion core/src/services/s3/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,11 @@ impl Accessor for S3Backend {
// The max multipart size of S3 is 5 GiB.
//
// ref: <https://docs.aws.amazon.com/AmazonS3/latest/userguide/qfacts.html>
write_multi_max_size: Some(5 * 1024 * 1024 * 1024),
write_multi_max_size: if cfg!(target_pointer_width = "64") {
Some(5 * 1024 * 1024 * 1024)
} else {
Some(usize::MAX)
},

create_dir: true,
delete: true,
Expand Down