Skip to content

chore(bindings/java): simplify library path resolution #3196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 1 commit into from
Sep 27, 2023
Merged

chore(bindings/java): simplify library path resolution #3196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions bindings/java/src/main/java/org/apache/opendal/NativeObject.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,20 +122,9 @@ private static void doLoadBundledLibrary() throws IOException {
}

private static String bundledLibraryPath() {
final String os = System.getProperty("os.name").toLowerCase();
final StringBuilder path = new StringBuilder("/native/" + Environment.getClassifier() + "/");
if (!os.startsWith("windows")) {
path.append("lib");
}
path.append("opendal_java");
if (os.startsWith("windows")) {
path.append(".dll");
} else if (os.startsWith("mac")) {
path.append(".dylib");
} else {
path.append(".so");
}
return path.toString();
final String classifier = Environment.getClassifier();
final String libraryName = System.mapLibraryName("opendal_java");
return "/native/" + classifier + "/" + libraryName;
}

/**
Expand Down