feat(bindings/python): Enable BlockingLayer for non-blocking services that don't support blocking#3198
Merged
Xuanwo merged 1 commit intoapache:mainfrom Sep 28, 2023
Merged
Conversation
Member
Seems it's not the latest code. I tested this PR locally with :) python
>>> import opendal
>>> op = opendal.Operator("s3", bucket="test", region="us-east-1")
thread '<unnamed>' panicked at 'blocking layer must be created: Unexpected (permanent) at => failed to get current handle
', bindings/python/src/lib.rs:70:59
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
pyo3_runtime.PanicException: blocking layer must be created: Unexpected (permanent) at => failed to get current handle |
Member
Author
|
That's odd, I've definitely rebased onto main before building... Anyway, it'd be nice to be able to use |
Xuanwo
reviewed
Sep 28, 2023
27f883a to
9141d57
Compare
BlockLayer for on-blocking services that don't support blockingBlockLayer for non-blocking services that don't support blocking
BlockLayer for non-blocking services that don't support blockingBlockingLayer for non-blocking services that don't support blocking
…es that don't support blocking
9141d57 to
81354a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why but it doesn't really work currently.