Skip to content

feat(services/persy): change blocking_x in async_x call to tokio::task::blocking_spawn#3221

Merged
Xuanwo merged 3 commits intoapache:mainfrom
Zheaoli:manjusaka/persy-spawn
Oct 13, 2023
Merged

feat(services/persy): change blocking_x in async_x call to tokio::task::blocking_spawn#3221
Xuanwo merged 3 commits intoapache:mainfrom
Zheaoli:manjusaka/persy-spawn

Conversation

@Zheaoli
Copy link
Copy Markdown
Member

@Zheaoli Zheaoli commented Sep 30, 2023

Signed-off-by: Manjusaka me@manjusaka.me

@Zheaoli Zheaoli requested a review from Xuanwo as a code owner September 30, 2023 15:33
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Sep 30, 2023
Comment thread core/src/types/error.rs Outdated
@Zheaoli Zheaoli force-pushed the manjusaka/persy-spawn branch from 3dbd390 to 582f1dc Compare September 30, 2023 15:41
Comment thread core/src/services/persy/backend.rs
@Zheaoli
Copy link
Copy Markdown
Member Author

Zheaoli commented Oct 1, 2023

I will split the error refactor into a single pr. This PR would be drafted first.

@Zheaoli Zheaoli marked this pull request as draft October 1, 2023 11:04
@Zheaoli Zheaoli force-pushed the manjusaka/persy-spawn branch 3 times, most recently from 7d84e5d to 74bffc0 Compare October 12, 2023 18:03
…k::blocking_spawn

Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli Zheaoli force-pushed the manjusaka/persy-spawn branch from 74bffc0 to ba8ae00 Compare October 12, 2023 18:05
@Zheaoli Zheaoli marked this pull request as ready for review October 12, 2023 18:05
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 3836074 into apache:main Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants