Skip to content

refactor(services/gdrive): Extract folder search logic#3234

Merged
Xuanwo merged 7 commits intomainfrom
polish-gdrive
Oct 16, 2023
Merged

refactor(services/gdrive): Extract folder search logic#3234
Xuanwo merged 7 commits intomainfrom
polish-gdrive

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Oct 7, 2023

No description provided.

@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Oct 7, 2023
Copy link
Copy Markdown
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement.

Comment thread core/src/services/gdrive/core.rs Outdated
Comment thread core/src/services/gdrive/core.rs Outdated
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Oct 7, 2023

Maybe it's better to extract the path cache logic out of gdrive for better understanding and test. I reverted all changes to cache logic and leave them to another PR.

@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Oct 7, 2023

test_blocking_copy_file always failed in CI but can't reproduce locally, I'm digging.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo changed the title refactor(services/gdrive): Use moka instead of Arc<Mutex<HashMap>> refactor(services/gdrive): Extract folder search logic Oct 16, 2023
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit 9b9230c into main Oct 16, 2023
@Xuanwo Xuanwo deleted the polish-gdrive branch October 16, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants