Skip to content

feat(service/d1): Support d1 for opendal#3248

Merged
Xuanwo merged 7 commits intoapache:mainfrom
ifmagic:dev/d1
Oct 13, 2023
Merged

feat(service/d1): Support d1 for opendal#3248
Xuanwo merged 7 commits intoapache:mainfrom
ifmagic:dev/d1

Conversation

@ifmagic
Copy link
Copy Markdown
Contributor

@ifmagic ifmagic commented Oct 9, 2023

for #3216

@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Oct 9, 2023
Xuanwo
Xuanwo reviewed Oct 9, 2023
View reviewed changes
Comment thread core/src/services/d1/backend.rs Outdated
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Oct 9, 2023

you can run the test via cargo test services_d1 --features services-d1

@ifmagic
Copy link
Copy Markdown
Contributor Author

ifmagic commented Oct 12, 2023

@Xuanwo I passed the local behavior, but d1 limited the Maximum string, BLOB or table row size to 1M, so before that I reduced gen_bytes locally.

@ifmagic ifmagic marked this pull request as ready for review October 12, 2023 09:33
@ifmagic ifmagic requested a review from PsiACE as a code owner October 12, 2023 09:33
Xuanwo
Xuanwo reviewed Oct 12, 2023
View reviewed changes
Comment thread core/src/services/d1/backend.rs Outdated
Comment thread core/src/services/d1/backend.rs Outdated
Comment thread core/src/services/d1/backend.rs Outdated
Comment thread core/src/services/d1/backend.rs Outdated
Comment thread core/src/services/d1/backend.rs Outdated
Comment thread core/src/services/d1/backend.rs Outdated
Comment thread core/src/services/d1/backend.rs
Comment thread core/src/services/d1/backend.rs Outdated
Comment thread core/src/services/d1/error.rs Outdated
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Oct 13, 2023

Mostly LGTM! The only thing left here is to make clippy happy. Please make sure you have rust updated to latest via rustup update.

Xuanwo
Xuanwo approved these changes Oct 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit eb4b136 into apache:main Oct 13, 2023
@ifmagic ifmagic deleted the dev/d1 branch October 13, 2023 08:53
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ifmagic @Xuanwo