feat(layer/prometheus): Support custom metric bucket for Histogram#3275
Merged
Xuanwo merged 9 commits intoapache:mainfrom Oct 15, 2023
Merged
feat(layer/prometheus): Support custom metric bucket for Histogram#3275Xuanwo merged 9 commits intoapache:mainfrom
Xuanwo merged 9 commits intoapache:mainfrom
Conversation
github-actions
Bot
added
the
releases-note/feat
Zheaoli
force-pushed
the
manjusaka/prometheus-layer
branch
from
bfa44b9 to
7e23f64
Compare
Xuanwo
reviewed
Oct 13, 2023
Xuanwo
reviewed
Oct 13, 2023
suyanhanx
reviewed
Oct 13, 2023
Zheaoli
force-pushed
the
manjusaka/prometheus-layer
branch
3 times, most recently
from
9b7a4bf to
47cac68
Compare
Xuanwo
reviewed
Oct 14, 2023
Zheaoli
force-pushed
the
manjusaka/prometheus-layer
branch
from
47cac68 to
4856eff
Compare
Xuanwo
reviewed
Oct 15, 2023
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Zheaoli
force-pushed
the
manjusaka/prometheus-layer
branch
from
1cf39f4 to
fe8327a
Compare
Xuanwo
reviewed
Oct 15, 2023
Co-authored-by: Xuanwo <github@xuanwo.io>
Co-authored-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Xuanwo
approved these changes
Oct 15, 2023
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Great! Thank you for your patience.
Xuanwo
approved these changes
Oct 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, the OpenDAL hardcode the metric bucket in Prometheus Histogram. In production, we always want to customize it depending on the file size and normal I/O time in out environment.
I make this PR try to make this option configable