Skip to content

refactor(bindings/C): Alter naming convention for consistency #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 18 commits into from
Oct 21, 2023
Merged

refactor(bindings/C): Alter naming convention for consistency #3282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
54d1024
chores
xyjixyjixyji Oct 14, 2023
9950051
rename opendal_lister as well
xyjixyjixyji Oct 14, 2023
ae08591
addresses few comments
xyjixyjixyji Oct 16, 2023
624454b
rename opendal_result_reader
xyjixyjixyji Oct 16, 2023
8cc01da
Merge remote-tracking branch 'origin/main' into chore_remove_blocking
Xuanwo Oct 20, 2023
4dcdb14
refactor
Xuanwo Oct 20, 2023
9b2d7c5
polish code
Xuanwo Oct 20, 2023
39fe4a9
Fix doc
Xuanwo Oct 20, 2023
5460a34
format
Xuanwo Oct 20, 2023
bd4599a
Fix go
Xuanwo Oct 20, 2023
290eda2
Fix zig
Xuanwo Oct 20, 2023
ddb1253
fix swift
Xuanwo Oct 20, 2023
5be79ba
Add upgrade docs
Xuanwo Oct 20, 2023
8396c43
Fix
Xuanwo Oct 20, 2023
97f7051
polish
Xuanwo Oct 20, 2023
a5bfa86
Make clippy happy
Xuanwo Oct 20, 2023
21fb113
Merge branch 'main' into chore_remove_blocking
Xuanwo Oct 21, 2023
b933f70
Format
Xuanwo Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bindings/c/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ all: build test examples

.PHONY: format
format:
cargo fmt
find . -name '*.cpp' -exec clang-format -i --style=WebKit --verbose {} \;
find . -name '*.c' -exec clang-format -i --style=WebKit --verbose {} \;

Expand Down
9 changes: 5 additions & 4 deletions bindings/c/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ A simple read and write example
int main()
{
/* Initialize a operator for "memory" backend, with no options */
opendal_operator_ptr op = opendal_operator_new("memory", 0);
assert(op.ptr != NULL);
opendal_result_operator_new result = opendal_operator_new("memory", 0);
assert(result.operator_ptr != NULL);
Comment thread
Xuanwo marked this conversation as resolved.
assert(result.error == NULL);

/* Prepare some data to be written */
opendal_bytes data = {
Expand All @@ -26,11 +27,11 @@ int main()
};

/* Write this into path "/testpath" */
opendal_error *error = opendal_operator_blocking_write(op, "/testpath", data);
opendal_error *error = opendal_operator_write(op, "/testpath", data);
assert(error == NULL);

/* We can read it out, make sure the data is the same */
opendal_result_read r = opendal_operator_blocking_read(op, "/testpath");
opendal_result_read r = opendal_operator_read(op, "/testpath");
opendal_bytes* read_bytes = r.data;
assert(r.error == NULL);
assert(read_bytes->len == 24);
Expand Down
8 changes: 4 additions & 4 deletions bindings/c/examples/basic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ int main()
{
/* Initialize a operator for "memory" backend, with no options */
opendal_result_operator_new result = opendal_operator_new("memory", 0);
assert(result.operator_ptr != NULL);
assert(result.op != NULL);
assert(result.error == NULL);

opendal_operator_ptr* op = result.operator_ptr;
opendal_operator* op = result.op;

/* Prepare some data to be written */
opendal_bytes data = {
Expand All @@ -37,11 +37,11 @@ int main()
};

/* Write this into path "/testpath" */
opendal_error* error = opendal_operator_blocking_write(op, "/testpath", data);
opendal_error* error = opendal_operator_write(op, "/testpath", data);
assert(error == NULL);

/* We can read it out, make sure the data is the same */
opendal_result_read r = opendal_operator_blocking_read(op, "/testpath");
opendal_result_read r = opendal_operator_read(op, "/testpath");
opendal_bytes* read_bytes = r.data;
assert(r.error == NULL);
assert(read_bytes->len == 24);
Expand Down
6 changes: 3 additions & 3 deletions bindings/c/examples/error_handle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ int main()
{
/* Initialize a operator for "memory" backend, with no options */
opendal_result_operator_new result = opendal_operator_new("memory", 0);
assert(result.operator_ptr != NULL);
assert(result.op != NULL);
assert(result.error == NULL);

opendal_operator_ptr* op = result.operator_ptr;
opendal_operator* op = result.op;

/* The read is supposed to fail */
opendal_result_read r = opendal_operator_blocking_read(op, "/testpath");
opendal_result_read r = opendal_operator_read(op, "/testpath");
assert(r.error != NULL);
assert(r.error->code == OPENDAL_NOT_FOUND);

Expand Down
Loading