Skip to content

chore(bindings/java): align mapping POJO pattern#3289

Merged
tisonkun merged 1 commit intoapache:mainfrom
tisonkun:refactor-java
Oct 15, 2023
Merged

chore(bindings/java): align mapping POJO pattern#3289
tisonkun merged 1 commit intoapache:mainfrom
tisonkun:refactor-java

Conversation

@tisonkun
Copy link
Copy Markdown
Member

Per #3277 (comment)

Align the POJO style -

  1. Generate getters for public final field to satisfy where only methods are accepted.
  2. Always overwrite the RequiredArgsConstructor for ensure the parameter order.

cc @Xuanwo @G-XD

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested review from G-XD and Xuanwo October 15, 2023 15:59
@Xuanwo Xuanwo changed the title style(bindings/java): align mapping POJO pattern chore(bindings/java): align mapping POJO pattern Oct 15, 2023
@github-actions github-actions Bot added the releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell label Oct 15, 2023
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tisonkun tisonkun merged commit 945ff82 into apache:main Oct 15, 2023
@tisonkun tisonkun deleted the refactor-java branch October 15, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants