Skip to content

feat(core): service add DBFS API 2.0 support#3334

Merged
Xuanwo merged 9 commits intoapache:mainfrom
morristai:feat/service_add_dbfs_api_2.0
Oct 26, 2023
Merged

feat(core): service add DBFS API 2.0 support#3334
Xuanwo merged 9 commits intoapache:mainfrom
morristai:feat/service_add_dbfs_api_2.0

Conversation

@morristai
Copy link
Copy Markdown
Member

@morristai morristai commented Oct 18, 2023 •
edited
Loading

Description

Additional Notes

  • Read operation is a bit tricky, as discussed here. As for now, it can read whole object and read for specific range, but reqwest::Body::bytes_stream() in poll_next() will not return whole response at once if the file is too big, which causes serde json failed. Will need to discuss for possible implementation.

TODO

  • Append write need to add new oio write trait, as we discuss here.
  • Add new GitHub Action e2e test workflow, but we need to setup Databricks cluster for this purpose.
  • Add necessary unit tests based on PR review.

@morristai morristai requested a review from Xuanwo as a code owner October 18, 2023 05:43
@morristai morristai marked this pull request as draft October 18, 2023 05:43
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Oct 18, 2023
Xuanwo
Xuanwo reviewed Oct 18, 2023
View reviewed changes
Comment thread core/src/raw/http_util/client.rs Outdated
Comment thread core/src/services/dbfs/backend.rs Outdated
Comment thread core/src/services/dbfs/backend.rs Outdated
Comment thread core/src/services/dbfs/backend.rs Outdated
Comment thread core/src/services/dbfs/backend.rs Outdated
Comment thread core/src/services/dbfs/backend.rs Outdated
Comment thread core/src/services/dbfs/backend.rs Outdated
Comment thread core/src/services/dbfs/reader.rs Outdated
@morristai morristai force-pushed the feat/service_add_dbfs_api_2.0 branch from 0109912 to a06ad4c Compare October 25, 2023 14:30
@morristai morristai marked this pull request as ready for review October 25, 2023 14:31
Xuanwo
Xuanwo reviewed Oct 25, 2023
View reviewed changes
Comment thread core/src/services/dbfs/reader.rs Outdated
Comment thread core/src/services/dbfs/reader.rs Outdated
Comment thread core/src/services/dbfs/reader.rs Outdated
Comment thread core/src/services/dbfs/reader.rs Outdated
Xuanwo
Xuanwo reviewed Oct 26, 2023
View reviewed changes
Comment thread core/src/services/dbfs/backend.rs Outdated
Comment thread core/src/services/dbfs/backend.rs
Comment thread core/src/services/dbfs/core.rs Outdated
Comment thread core/src/services/dbfs/reader.rs Outdated
Comment thread core/src/services/dbfs/reader.rs Outdated
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Oct 26, 2023

By the way, testing DBFS can be challenging as Databricks is a substantial project that we require:

image

@morristai
Copy link
Copy Markdown
Member Author

morristai commented Oct 26, 2023

By the way, testing DBFS can be challenging as Databricks is a substantial project that we require:

image

Is there anything I can do on my end?

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Oct 26, 2023

Is there anything I can do on my end?

I assume we require a sponsor to provide us with a Databricks workspace for testing.

Xuanwo
Xuanwo approved these changes Oct 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, let's rock!

@Xuanwo Xuanwo merged commit a4b260a into apache:main Oct 26, 2023
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add new service support: DBFS API 2.0

2 participants

@morristai @Xuanwo