feat(layer/prometheus): Support output path as a metric label#3335
Merged
Xuanwo merged 1 commit intoapache:mainfrom Oct 21, 2023
Merged
feat(layer/prometheus): Support output path as a metric label#3335Xuanwo merged 1 commit intoapache:mainfrom
Xuanwo merged 1 commit intoapache:mainfrom
Conversation
bce7287 to
ae47b29
Compare
Xuanwo
reviewed
Oct 18, 2023
Xuanwo
reviewed
Oct 18, 2023
7011430 to
2175906
Compare
Xuanwo
reviewed
Oct 20, 2023
c8e9df2 to
6c8456f
Compare
Signed-off-by: Manjusaka <me@manjusaka.me>
6c8456f to
3281dde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, we already have basic metric output in the Prometheus layer.
All the metrics are grouped by scheme and operation for now.
For now, in some circumstances, we need to group by the metric by an extra path. Here's an example: if we choose to write to different devices in Linux using OpenDAL, and one of the devices has some problem, the write and read action becomes slow and slow. We can't monitor and alert for the specific device if we don't have a path label.
But on the other hand, if we output all the paths as a label in metric, the final metric we get will be extremely massive. So I chose to introduce a new config option for the people to choose how many path levels they want to export