Skip to content

feat(bindings/java): Migrate behavior tests to new Workflow Planner#3341

Merged
Xuanwo merged 6 commits intomainfrom
add-java-test-support
Oct 18, 2023
Merged

feat(bindings/java): Migrate behavior tests to new Workflow Planner#3341
Xuanwo merged 6 commits intomainfrom
add-java-test-support

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Oct 18, 2023

No description provided.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from PsiACE as a code owner October 18, 2023 12:03
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Oct 18, 2023
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested review from G-XD and tisonkun October 18, 2023 12:30
@tisonkun
Copy link
Copy Markdown
Member

It seems Java S3 service test is not run after this change?

@tisonkun
Copy link
Copy Markdown
Member

image

Only redis test run.

@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Oct 18, 2023

It seems Java S3 service test is not run after this change?

Excluded by our planner. Let's add a new rule.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Oct 18, 2023

cc @tisonkun, would you like to take another look?

Copy link
Copy Markdown
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't check the py files closely. The result seems good. Let's give it a try.

@Xuanwo Xuanwo merged commit e80e32c into main Oct 18, 2023
@Xuanwo Xuanwo deleted the add-java-test-support branch October 18, 2023 13:14
@tisonkun
Copy link
Copy Markdown
Member

FWIW - we can later polish the CI job name, it's a bit LTA (less than awesome if I bikeshedding a bit XD)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants