Skip to content

feat(service/cloudflare_kv): support cloudflare KV#3348

Merged
Xuanwo merged 8 commits intoapache:mainfrom
my-vegetable-has-exploded:cf-kv
Oct 23, 2023
Merged

feat(service/cloudflare_kv): support cloudflare KV#3348
Xuanwo merged 8 commits intoapache:mainfrom
my-vegetable-has-exploded:cf-kv

Conversation

@my-vegetable-has-exploded
Copy link
Copy Markdown
Contributor

close #3217

Implement cloudflare kv support via our KV adaptor.

@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Oct 19, 2023
@Xuanwo Xuanwo changed the title feat(service/Cloudflare kv):support cloudflare KV feat(service/cloudflare_kv):support cloudflare KV Oct 19, 2023
@Xuanwo Xuanwo changed the title feat(service/cloudflare_kv):support cloudflare KV feat(service/cloudflare_kv): support cloudflare KV Oct 19, 2023
Comment thread core/src/services/cloudflare_kv/backend.rs Outdated
Comment thread core/src/services/cloudflare_kv/backend.rs
Comment thread core/src/services/cloudflare_kv/backend.rs Outdated
Comment thread core/src/services/cloudflare_kv/backend.rs Outdated
Comment thread core/src/services/cloudflare_kv/backend.rs Outdated
Comment thread core/src/services/cloudflare_kv/backend.rs Outdated
Comment thread core/src/services/cloudflare_kv/backend.rs Outdated
Comment thread core/src/services/cloudflare_kv/backend.rs Outdated
Comment thread core/src/services/cloudflare_kv/backend.rs Outdated
Comment thread core/src/services/cloudflare_kv/backend.rs
init cloudflare-kv

implement builder.

Implement read

implement scan

feat(service/Cloudflare kv):support cloudflare KV
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! The only thing left is make sure our files have correct licenses.

Comment thread core/src/services/cloudflare_kv/backend.rs Outdated
Comment thread core/src/services/cloudflare_kv/backend.rs Outdated
Comment thread core/src/services/cloudflare_kv/backend.rs Outdated
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 429972b into apache:main Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add cloudflare KV support

2 participants