Skip to content

refactor(service/postgresql): Migrate task to new task planner#3358

Merged
Xuanwo merged 3 commits intoapache:mainfrom
Zheaoli:manjusaka/migrate-postgresql-task
Oct 23, 2023
Merged

refactor(service/postgresql): Migrate task to new task planner#3358
Xuanwo merged 3 commits intoapache:mainfrom
Zheaoli:manjusaka/migrate-postgresql-task

Conversation

@Zheaoli
Copy link
Copy Markdown
Member

@Zheaoli Zheaoli commented Oct 23, 2023

Signed-off-by: Manjusaka me@manjusaka.me

@Zheaoli Zheaoli requested review from PsiACE and Xuanwo as code owners October 23, 2023 04:02
@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Oct 23, 2023
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have behavior test for pg before?

@Zheaoli
Copy link
Copy Markdown
Member Author

Zheaoli commented Oct 23, 2023

We don't have behavior test for pg before?

No we have, I missed some diff

Update pr later.

Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli Zheaoli force-pushed the manjusaka/migrate-postgresql-task branch from 9eb8fa5 to 272298c Compare October 23, 2023 05:09
@Zheaoli Zheaoli requested a review from Xuanwo October 23, 2023 05:09
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 73eea44 into apache:main Oct 23, 2023
@Zheaoli Zheaoli deleted the manjusaka/migrate-postgresql-task branch October 23, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants