Skip to content

refactor(services/cos,obs): migrate to test planner#3371

Merged
Xuanwo merged 1 commit intomainfrom
oss-planner
Oct 25, 2023
Merged

refactor(services/cos,obs): migrate to test planner#3371
Xuanwo merged 1 commit intomainfrom
oss-planner

Conversation

@suyanhanx
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Oct 24, 2023
@suyanhanx
Copy link
Copy Markdown
Member Author

I noticed that OSS is still using secret. Should we migrate it to 1p as well? @Xuanwo

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Oct 24, 2023

I noticed that OSS is still using secret. Should we migrate it to 1p as well? @Xuanwo

Yep, I will work on this with @everpcpc.

@Xuanwo Xuanwo marked this pull request as ready for review October 25, 2023 05:44
@Xuanwo Xuanwo requested review from PsiACE and Xuanwo as code owners October 25, 2023 05:44
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 4812aa1 into main Oct 25, 2023
@Xuanwo Xuanwo deleted the oss-planner branch October 25, 2023 05:45
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Oct 25, 2023

Hi, @suyanhanx. The OSS's secrets have been added to 1Password. You can proceed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants