Skip to content

refactor(service/redis): Migrate task to new task planner#3374

Merged
Xuanwo merged 10 commits intoapache:mainfrom
sunheyi6:redis-tls
Nov 17, 2023
Merged

refactor(service/redis): Migrate task to new task planner#3374
Xuanwo merged 10 commits intoapache:mainfrom
sunheyi6:redis-tls

Conversation

@sunheyi6
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Oct 25, 2023
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redis is intentionally left as it is, because we have some complex features to sort out.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 3, 2023

#3471 has been merged, you can continue your work now!

# Conflicts:
#	.github/workflows/service_test_redis.yml
@sunheyi6
Copy link
Copy Markdown
Contributor Author

sunheyi6 commented Nov 6, 2023

@Xuanwo cc

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix failing CI first.

Comment thread .github/services/redis/redis_with_cluster_tls/action.yml Outdated
Comment thread .github/services/redis/redis_tls/action.yml Outdated
@sunheyi6
Copy link
Copy Markdown
Contributor Author

@G-XD Can you help me check why my redis-with-cluster-cls did not pass the CI test? I have tried quite a bit, but it seems that I can't solve this problem.

Comment thread .github/services/redis/redis_with_cluster_tls/action.yml
@sunheyi6
Copy link
Copy Markdown
Contributor Author

@PsiACE cc

Copy link
Copy Markdown
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sunheyi6
Copy link
Copy Markdown
Contributor Author

@Xuanwo cc

@Xuanwo Xuanwo merged commit ae1a534 into apache:main Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants