Skip to content

refactor(services/webdav): migrate to test planner for webdav#3379

Merged
Xuanwo merged 16 commits intoapache:mainfrom
shauvet:test-webdav
Nov 2, 2023
Merged

refactor(services/webdav): migrate to test planner for webdav#3379
Xuanwo merged 16 commits intoapache:mainfrom
shauvet:test-webdav

Conversation

@shauvet
Copy link
Copy Markdown
Contributor

@shauvet shauvet commented Oct 25, 2023 •
edited
Loading

related with #3267

@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Oct 25, 2023
Xuanwo
Xuanwo reviewed Oct 25, 2023
View reviewed changes
Comment thread .github/workflows/service_test_webdav.yml
Xuanwo
Xuanwo reviewed Oct 25, 2023
View reviewed changes
Comment thread .github/services/webdav/nginx_with_redirect/action.yml Outdated
Xuanwo
Xuanwo reviewed Oct 26, 2023
View reviewed changes
Comment thread .github/services/owncloud/owncloud/action.yml Outdated
Xuanwo
Xuanwo reviewed Oct 26, 2023
View reviewed changes
Comment thread .github/services/nextcloud/nextcloud/action.yml
Xuanwo
Xuanwo reviewed Oct 26, 2023
View reviewed changes
Comment thread fixtures/nextcloud/docker-compose.yml Outdated
Comment thread fixtures/owncloud/docker-compose.yml Outdated
@Zheaoli
Copy link
Copy Markdown
Member

Zheaoli commented Oct 26, 2023

I will review this PR，cc @Xuanwo

Zheaoli
Zheaoli reviewed Oct 27, 2023
View reviewed changes
Comment thread .github/services/webdav/nginx/action.yml Outdated
Comment thread .github/services/webdav/nginx_with_empty_password/action.yml Outdated
Comment thread .github/services/webdav/nginx_with_password/action.yml Outdated
Comment thread fixtures/nextcloud/docker-compose.yml
Comment thread fixtures/owncloud/docker-compose.yml Outdated
@shauvet shauvet marked this pull request as ready for review October 27, 2023 12:51
@shauvet shauvet requested a review from PsiACE as a code owner October 27, 2023 12:51
Zheaoli
Zheaoli approved these changes Oct 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Zheaoli Zheaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @Xuanwo

@Xuanwo Xuanwo mentioned this pull request Oct 29, 2023
Closed
@dqhl76 dqhl76 mentioned this pull request Oct 29, 2023
Closed
86 tasks
@Zheaoli
Copy link
Copy Markdown
Member

Zheaoli commented Oct 31, 2023

Please squash the commit

BTW plz use git pull --rebase when you update from the upstream

@suyanhanx
Copy link
Copy Markdown
Member

suyanhanx commented Oct 31, 2023

Please squash the commit

We don't ask for this.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Oct 31, 2023

I'm not sure if this error related to #3429

>       operator.write(filename, content)
E       opendal.Error: Unexpected (temporary) at write, context: { url: http://127.0.0.1:8080/remote.php/webdav//, called: http_util::Client::send_async, service: webdav, path: random_file_722b4c6d-b06e-49e1-a9d6-10c311f50e68 } => send async request, source: error sending request for url

@Zheaoli
Copy link
Copy Markdown
Member

Zheaoli commented Nov 1, 2023

you can take a look at #3448, add health check for docker compose would better

@shauvet
Copy link
Copy Markdown
Contributor Author

shauvet commented Nov 1, 2023

you can take a look at #3448, add health check for docker compose would better

I've added the health check for nextcloud and owncloud. But it still cannot check pass, I'm not sure the reason.

@Zheaoli
Copy link
Copy Markdown
Member

Zheaoli commented Nov 1, 2023

@shauvet Would you mind I modify some code on your PR?

@shauvet
Copy link
Copy Markdown
Contributor Author

shauvet commented Nov 1, 2023

@shauvet Would you mind I modify some code on your PR?

I don't mind. Please.

@Zheaoli
Update health check for nextcloud
de229c7 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Update service file
b508940 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Copy link
Copy Markdown
Member

Zheaoli commented Nov 1, 2023

@Xuanwo @shauvet the test has been passed, the PR is ready to merge

Zheaoli
Zheaoli approved these changes Nov 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Zheaoli Zheaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 2, 2023

Thanks a lot!

@Xuanwo Xuanwo merged commit 9bcb834 into apache:main Nov 2, 2023
@shauvet shauvet deleted the test-webdav branch November 2, 2023 11:13
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PsiACE PsiACE Awaiting requested review from PsiACE

@Xuanwo Xuanwo Awaiting requested review from Xuanwo Xuanwo is a code owner

@Zheaoli Zheaoli Awaiting requested review from Zheaoli

@suyanhanx suyanhanx Awaiting requested review from suyanhanx

Assignees

No one assigned

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shauvet @Zheaoli @suyanhanx @Xuanwo