Skip to content

refactor(service/dropbox): migrate to test planner#3381

Merged
Xuanwo merged 1 commit intomainfrom
dropbox-test-planner
Oct 30, 2023
Merged

refactor(service/dropbox): migrate to test planner#3381
Xuanwo merged 1 commit intomainfrom
dropbox-test-planner

Conversation

@suyanhanx
Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Oct 25, 2023
@suyanhanx
Copy link
Copy Markdown
Member Author

suyanhanx commented Oct 25, 2023

@suyanhanx suyanhanx force-pushed the dropbox-test-planner branch from d96eff9 to 153bb9d Compare October 25, 2023 16:38
@tisonkun
Copy link
Copy Markdown
Member

tisonkun commented Oct 25, 2023

Interesting. This seems a dropbox limitation where we can skip the test case for this special service.

That is, Dropbox seems not support unicode emoji in path.

@suyanhanx
Copy link
Copy Markdown
Member Author

suyanhanx commented Oct 25, 2023

Interesting. This seems a dropbox limitation where we can skip the test case for this special service.

That is, Dropbox seems not support unicode emoji in path.

I'll add a test to core and give it a try.
The case has been removed.

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx force-pushed the dropbox-test-planner branch from c3b7c6a to fde5056 Compare October 30, 2023 14:01
@suyanhanx suyanhanx marked this pull request as ready for review October 30, 2023 14:59
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit d60befd into main Oct 30, 2023
@Xuanwo Xuanwo deleted the dropbox-test-planner branch October 30, 2023 15:14
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Oct 30, 2023

License check failed

[main] INFO io.korandoru.hawkeye.command.HawkEyeCommandCheck - Found missing header files: [/github/workspace/.github/workflows/service_test_dropbox.yml]

@suyanhanx
Copy link
Copy Markdown
Member Author

License check failed

[main] INFO io.korandoru.hawkeye.command.HawkEyeCommandCheck - Found missing header files: [/github/workspace/.github/workflows/service_test_dropbox.yml]

Let me take a look

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Oct 30, 2023

Let me take a look

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants