Skip to content

chore(bindings/java): use JDK 8 time APIs#3400

Merged
tisonkun merged 2 commits intoapache:mainfrom
tisonkun:usenewjavatime
Oct 27, 2023
Merged

chore(bindings/java): use JDK 8 time APIs#3400
tisonkun merged 2 commits intoapache:mainfrom
tisonkun:usenewjavatime

Conversation

@tisonkun
Copy link
Copy Markdown
Member

@tisonkun tisonkun commented Oct 27, 2023

  1. More precise than Date.
  2. Can convert to DateTimes with atZone or atOffset.

@tisonkun
chore(bindings/java): use JDK 8 time APIs
f07622d 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested review from G-XD and Xuanwo and removed request for G-XD October 27, 2023 01:08
@tisonkun tisonkun self-assigned this Oct 27, 2023
@github-actions github-actions Bot added the releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell label Oct 27, 2023
Xuanwo
Xuanwo reviewed Oct 27, 2023
View reviewed changes
Comment thread bindings/java/src/lib.rs Outdated
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Oct 27, 2023

By the way, is this a breaking change since v0.41?

@tisonkun
construct instant with nano adj
22dfcc5 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Copy Markdown
Member Author

tisonkun commented Oct 27, 2023

By the way, is this a breaking change since v0.41?

@Xuanwo

No. The field is introduced by 3108bd3 which is unreleased yet.

Xuanwo
Xuanwo approved these changes Oct 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tisonkun
Copy link
Copy Markdown
Member Author

tisonkun commented Oct 27, 2023

I'm going to make some convert functions for DateTime and Duration, which I plan to do after make some utilities for construct signatures.

@tisonkun tisonkun merged commit 3d0d48d into apache:main Oct 27, 2023
@tisonkun tisonkun deleted the usenewjavatime branch October 27, 2023 07:32
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@G-XD G-XD Awaiting requested review from G-XD

Assignees

@tisonkun tisonkun

Labels

releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tisonkun @Xuanwo