Skip to content

fix(binding/java): fix return value of presign-related method#3433

Merged
Xuanwo merged 4 commits intomainfrom
fix_binding_java
Oct 31, 2023
Merged

fix(binding/java): fix return value of presign-related method#3433
Xuanwo merged 4 commits intomainfrom
fix_binding_java

Conversation

@G-XD
Copy link
Copy Markdown
Contributor

@G-XD G-XD commented Oct 31, 2023

Fix error and add behavior test for presign.

@G-XD G-XD requested a review from tisonkun as a code owner October 31, 2023 12:13
@github-actions github-actions Bot added the releases-note/fix The PR fixes a bug or has a title that begins with "fix" label Oct 31, 2023
Comment thread bindings/java/pom.xml
Copy link
Copy Markdown
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Only one comment inline.

@G-XD G-XD marked this pull request as draft October 31, 2023 14:30
@G-XD G-XD marked this pull request as ready for review October 31, 2023 16:50
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 8df75c5 into main Oct 31, 2023
@Xuanwo Xuanwo deleted the fix_binding_java branch October 31, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/fix The PR fixes a bug or has a title that begins with "fix"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants