Skip to content

ci: Switch to 1password connect to avoid rate limit #3447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 9 commits into from
Nov 1, 2023
Merged

ci: Switch to 1password connect to avoid rate limit #3447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
16aba7d
ci: Switch to 1password connect to avoid rate limit
Xuanwo Nov 1, 2023
1963fa0
Fix typo
Xuanwo Nov 1, 2023
21301b0
FIx typo
Xuanwo Nov 1, 2023
2b06a90
Test
Xuanwo Nov 1, 2023
d4e558b
Fix typo
Xuanwo Nov 1, 2023
d69e9c2
Migrate all
Xuanwo Nov 1, 2023
f7907b8
Merge branch 'main' into migrate-to-connect
Xuanwo Nov 1, 2023
2c37f95
Test
Xuanwo Nov 1, 2023
7a1c92a
Merge remote-tracking branch 'refs/remotes/origin/migrate-to-connect'…
Xuanwo Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/scripts/behavior_test/plan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ def provided_cases() -> list[dict[str, str]]:

# Check if this workflow needs to read secrets.
#
# We will check if pattern `secrets.XXX` exist in content.
# We will check if pattern `op://services` exist in content.
if not os.getenv("GITHUB_HAS_SECRETS") == "true":
cases[:] = [v for v in cases if "secrets" not in v["content"]]
cases[:] = [v for v in cases if "op://services" not in v["content"]]

# Remove content from cases.
cases = [
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/behavior_test_binding_java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,12 @@ jobs:
# TODO: 1password is only supported on linux
#
# Waiting for https://github.com/1Password/load-secrets-action/issues/46
- name: Setup service account token for 1password
- name: Setup 1Password Connect
if: runner.os == 'Linux'
shell: bash
run: echo "OP_SERVICE_ACCOUNT_TOKEN=${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}" >> $GITHUB_ENV
uses: 1password/load-secrets-action/configure@v1
with:
connect-host: ${{ secrets.OP_CONNECT_HOST }}
connect-token: ${{ secrets.OP_CONNECT_TOKEN }}

- name: Test Core
uses: ./.github/actions/behavior_test_binding_java
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/behavior_test_binding_python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,13 @@ jobs:
# TODO: 1password is only supported on linux
#
# Waiting for https://github.com/1Password/load-secrets-action/issues/46
- name: Setup service account token for 1password
- name: Setup 1Password Connect
if: runner.os == 'Linux'
shell: bash
run: echo "OP_SERVICE_ACCOUNT_TOKEN=${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}" >> $GITHUB_ENV
uses: 1password/load-secrets-action/configure@v1
with:
connect-host: ${{ secrets.OP_CONNECT_HOST }}
connect-token: ${{ secrets.OP_CONNECT_TOKEN }}

- uses: actions/setup-python@v4
with:
python-version: '3.11'
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/behavior_test_core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,12 @@ jobs:
# TODO: 1password is only supported on linux
#
# Waiting for https://github.com/1Password/load-secrets-action/issues/46
- name: Setup service account token for 1password
- name: Setup 1Password Connect
if: runner.os == 'Linux'
shell: bash
run: echo "OP_SERVICE_ACCOUNT_TOKEN=${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}" >> $GITHUB_ENV
uses: 1password/load-secrets-action/configure@v1
with:
connect-host: ${{ secrets.OP_CONNECT_HOST }}
connect-token: ${{ secrets.OP_CONNECT_TOKEN }}

- name: Test Core
uses: ./.github/actions/behavior_test_core
Expand Down