Skip to content

fix: nodejs test adapt OPENDAL_DISABLE_RANDOM_ROOT#3456

Merged
Xuanwo merged 7 commits intomainfrom
random-root-nodejs-test
Nov 1, 2023
Merged

fix: nodejs test adapt OPENDAL_DISABLE_RANDOM_ROOT#3456
Xuanwo merged 7 commits intomainfrom
random-root-nodejs-test

Conversation

@suyanhanx
Copy link
Copy Markdown
Member

@suyanhanx suyanhanx commented Nov 1, 2023

close #3452

@github-actions github-actions Bot added the releases-note/fix The PR fixes a bug or has a title that begins with "fix" label Nov 1, 2023
Comment thread bindings/nodejs/tests/utils.mjs Outdated
Comment thread bindings/nodejs/tests/utils.mjs Outdated
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx force-pushed the random-root-nodejs-test branch from 151c32b to 13daaee Compare November 1, 2023 12:25
Comment thread .github/workflows/bindings_nodejs.yml
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx force-pushed the random-root-nodejs-test branch from 13daaee to 9d6f99a Compare November 1, 2023 12:51
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo marked this pull request as ready for review November 1, 2023 13:50
@Xuanwo Xuanwo requested a review from PsiACE as a code owner November 1, 2023 13:50
@Xuanwo Xuanwo merged commit 6e44078 into main Nov 1, 2023
@Xuanwo Xuanwo deleted the random-root-nodejs-test branch November 1, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/fix The PR fixes a bug or has a title that begins with "fix"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bindings/nodejs: Add OPENDAL_DISABLE_RANDOM_ROOT support for behavior testing

2 participants