Skip to content

refactor(services/redis): Enable rustls support by default for redis #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 1 commit into from
Nov 3, 2023
Merged

refactor(services/redis): Enable rustls support by default for redis #3471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ jobs:
services-postgresql
services-redb
services-redis
services-redis-rustls
# TODO: we need to find ways to using pre-install rocksdb library
# services-rocksdb
services-s3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/service_test_redis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
- name: Test
shell: bash
working-directory: core
run: cargo nextest run behavior --features tests,services-redis-rustls
run: cargo nextest run behavior --features tests,services-redis
env:
OPENDAL_TEST: redis
OPENDAL_REDIS_ENDPOINT: rediss://localhost:6379
Expand Down Expand Up @@ -94,7 +94,7 @@ jobs:
- name: Test
shell: bash
working-directory: core
run: cargo nextest run behavior --features tests,services-redis-rustls
run: cargo nextest run behavior --features tests,services-redis
env:
OPENDAL_TEST: redis
OPENDAL_REDIS_CLUSTER_ENDPOINTS: rediss://127.0.0.1:6380/,rediss://127.0.0.1:6381/,rediss://127.0.0.1:6382/,rediss://127.0.0.1:6383/,rediss://127.0.0.1:6384/,rediss://127.0.0.1:6385/
Expand Down
2 changes: 0 additions & 2 deletions bindings/java/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ services-all = [
"services-mysql",
"services-redb",
"services-redis",
"services-redis-rustls",
"services-rocksdb",
"services-sled",
"services-supabase",
Expand Down Expand Up @@ -122,7 +121,6 @@ services-persy = ["opendal/services-persy"]
services-postgresql = ["opendal/services-postgresql"]
services-redb = ["opendal/services-redb"]
services-redis = ["opendal/services-redis"]
services-redis-rustls = ["opendal/services-redis-rustls"]
services-rocksdb = ["opendal/services-rocksdb"]
services-sftp = ["opendal/services-sftp"]
services-sled = ["opendal/services-sled"]
Expand Down
2 changes: 0 additions & 2 deletions bindings/nodejs/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ services-all = [
"services-mysql",
"services-redb",
"services-redis",
"services-redis-rustls",
"services-rocksdb",
"services-sled",
"services-supabase",
Expand Down Expand Up @@ -118,7 +117,6 @@ services-persy = ["opendal/services-persy"]
services-postgresql = ["opendal/services-postgresql"]
services-redb = ["opendal/services-redb"]
services-redis = ["opendal/services-redis"]
services-redis-rustls = ["opendal/services-redis-rustls"]
services-rocksdb = ["opendal/services-rocksdb"]
services-sftp = ["opendal/services-sftp"]
services-sled = ["opendal/services-sled"]
Expand Down
2 changes: 0 additions & 2 deletions bindings/python/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ services-all = [
"services-mysql",
"services-redb",
"services-redis",
"services-redis-rustls",
"services-rocksdb",
"services-sled",
"services-supabase",
Expand Down Expand Up @@ -118,7 +117,6 @@ services-persy = ["opendal/services-persy"]
services-postgresql = ["opendal/services-postgresql"]
services-redb = ["opendal/services-redb"]
services-redis = ["opendal/services-redis"]
services-redis-rustls = ["opendal/services-redis-rustls"]
services-rocksdb = ["opendal/services-rocksdb"]
services-sftp = ["opendal/services-sftp"]
services-sled = ["opendal/services-sled"]
Expand Down
3 changes: 1 addition & 2 deletions core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,8 @@ services-oss = [
services-persy = ["dep:persy"]
services-postgresql = ["dep:tokio-postgres", "dep:bb8", "dep:bb8-postgres"]
services-redb = ["dep:redb"]
services-redis = ["dep:redis"]
services-redis = ["dep:redis", "redis?/tokio-rustls-comp"]
services-redis-native-tls = ["services-redis", "redis?/tokio-native-tls-comp"]
services-redis-rustls = ["services-redis", "redis?/tokio-rustls-comp"]
services-rocksdb = ["dep:rocksdb"]
services-s3 = [
"dep:reqsign",
Expand Down