Skip to content

refactor(bindings/python): Refactor layout for python bindings #3473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 2 commits into from
Nov 3, 2023
Merged

refactor(bindings/python): Refactor layout for python bindings #3473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c70f598
remove submodule
Xuanwo Nov 3, 2023
cf92431
refactor(bindings/python): Refactor layout for python bindings
Xuanwo Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions bindings/python/src/layers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@

use std::time::Duration;

use ::opendal as od;
use opendal::Operator;
use pyo3::prelude::*;

use crate::*;

pub trait PythonLayer: Send + Sync {
fn layer(&self, op: Operator) -> Operator;
}
Expand All @@ -30,7 +31,7 @@ pub struct Layer(pub Box<dyn PythonLayer>);

#[pyclass(module = "opendal.layers", extends=Layer)]
#[derive(Clone)]
pub struct RetryLayer(od::layers::RetryLayer);
pub struct RetryLayer(ocore::layers::RetryLayer);

impl PythonLayer for RetryLayer {
fn layer(&self, op: Operator) -> Operator {
Expand All @@ -55,7 +56,7 @@ impl RetryLayer {
max_delay: Option<f64>,
min_delay: Option<f64>,
) -> PyResult<PyClassInitializer<Self>> {
let mut retry = od::layers::RetryLayer::default();
let mut retry = ocore::layers::RetryLayer::default();
if let Some(max_times) = max_times {
retry = retry.with_max_times(max_times);
}
Expand All @@ -79,10 +80,3 @@ impl RetryLayer {
Ok(class)
}
}

pub fn create_submodule(py: Python) -> PyResult<&PyModule> {
let submod = PyModule::new(py, "layers")?;
submod.add_class::<Layer>()?;
submod.add_class::<RetryLayer>()?;
Ok(submod)
}
Loading