feat(bindings/python)!: Implement File and AsyncFile to replace Reader#3474
Merged
feat(bindings/python)!: Implement File and AsyncFile to replace Reader#3474
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Zheaoli
approved these changes
Nov 3, 2023
Member
Zheaoli
left a comment
There was a problem hiding this comment.
Mostly LGTM
Here may be something to follow up
- In Python, People may use r+b to use read and write API in the same object
- We may need test for context manager
Member
Author
This is not allowed in opendal. We can't and don't want to support this use case. |
messense
approved these changes
Nov 4, 2023
messense
reviewed
Nov 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python users don't know about reader and writer, they are using File-like objects and context manager.
This PR add
Operator::openandAsnycFileto make our API more native to python users.Async version:
Blocking version:
Writer is also supported in the same way:
Close #2570
Only
wbandrbsupported so far.