Skip to content

fix(bindings/python): fix type annotations and improve docs#3483

Merged
Xuanwo merged 1 commit intoapache:mainfrom
messense:improve-py-typing-docs
Nov 4, 2023
Merged

fix(bindings/python): fix type annotations and improve docs#3483
Xuanwo merged 1 commit intoapache:mainfrom
messense:improve-py-typing-docs

Conversation

@messense
Copy link
Copy Markdown
Member

@messense messense commented Nov 4, 2023

| syntax for union type is only supported on Python 3.10+.

Also formatted code with Black, the change is minimal so doesn't seem to worth a separate PR.

@github-actions github-actions Bot added the releases-note/fix The PR fixes a bug or has a title that begins with "fix" label Nov 4, 2023
@messense messense requested review from Xuanwo and Zheaoli November 4, 2023 02:59
@messense messense force-pushed the improve-py-typing-docs branch from 1eef3b8 to 18d15b9 Compare November 4, 2023 03:00
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit d27dc3e into apache:main Nov 4, 2023
@messense messense deleted the improve-py-typing-docs branch November 4, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/fix The PR fixes a bug or has a title that begins with "fix"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants