Skip to content

feat(services): Implement ConfigDeserializer and add S3Config as example#3490

Merged
Xuanwo merged 3 commits intomainfrom
config-refactor
Nov 6, 2023
Merged

feat(services): Implement ConfigDeserializer and add S3Config as example#3490
Xuanwo merged 3 commits intomainfrom
config-refactor

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Nov 6, 2023

Part of #3240

@Xuanwo Xuanwo requested review from PsiACE and suyanhanx November 6, 2023 12:31
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Nov 6, 2023
Comment thread core/src/services/s3/backend.rs
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from suyanhanx November 6, 2023 12:59
Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Copy Markdown
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo Xuanwo merged commit 2ef5465 into main Nov 6, 2023
@Xuanwo Xuanwo deleted the config-refactor branch November 6, 2023 13:25
@Xuanwo Xuanwo mentioned this pull request Nov 6, 2023
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants