feat: add mongodb gridfs service support#3491
Merged
Xuanwo merged 4 commits intoapache:mainfrom Nov 7, 2023
ifmagic:dev/gridfs
Merged
feat: add mongodb gridfs service support#3491Xuanwo merged 4 commits intoapache:mainfrom ifmagic:dev/gridfs
Xuanwo merged 4 commits intoapache:mainfrom
ifmagic:dev/gridfs
Conversation
github-actions
Bot
added
the
releases-note/feat
Xuanwo
reviewed
Nov 6, 2023
Zheaoli
previously requested changes
Nov 7, 2023
Member
Zheaoli
left a comment
Zheaoli
left a comment
There was a problem hiding this comment.
MOST LGTM
BTW I think we need behavior test here like other services
Member
We can split to another PR. |
Xuanwo
dismissed
Zheaoli’s stale review
It's better not to expand on contributors' work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #3315