Skip to content

feat(services/sqlite): add SqliteConfig#3497

Merged
Xuanwo merged 1 commit intoapache:mainfrom
hoslo:config-refactor-sqlite
Nov 7, 2023
Merged

feat(services/sqlite): add SqliteConfig#3497
Xuanwo merged 1 commit intoapache:mainfrom
hoslo:config-refactor-sqlite

Conversation

@hoslo
Copy link
Copy Markdown
Contributor

@hoslo hoslo commented Nov 7, 2023

Part of #3240

@hoslo hoslo requested a review from Xuanwo as a code owner November 7, 2023 03:46
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Nov 7, 2023
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 7, 2023

Hi, please ensure you use the same email (or at least linked to your GitHub account) when submitting patches. This helps us verify they're from you and avoid potential licensing issues.

The ASF mandates that all contributions meet the requirements.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 7, 2023

Hi, 48e6a99 still has the same problem:

Is shuai_yang@i***g.net a valid email? Can you connect this mail with your github account?

@hoslo
Copy link
Copy Markdown
Contributor Author

hoslo commented Nov 7, 2023

Hi, 48e6a99 still has the same problem:

Is shuai_yang@i***g.net a valid email? Can you connect this mail with your github account?

Just a moment, please. Let me check

@suyanhanx
Copy link
Copy Markdown
Member

suyanhanx commented Nov 7, 2023

The pgsql part has been finished in #3495.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 7, 2023

The pgsql part has been finished in #3495.

Yep, this is the another issue. This PR seems contain changes from others, maybe we need to Update branch.

@hoslo
Copy link
Copy Markdown
Contributor Author

hoslo commented Nov 7, 2023

Hi, 48e6a99 still has the same problem:

Is shuai_yang@i***g.net a valid email? Can you connect this mail with your github account?

I modified it

Xuanwo
Xuanwo approved these changes Nov 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 199a0a5 into apache:main Nov 7, 2023
@Xuanwo Xuanwo mentioned this pull request Nov 7, 2023
Closed
47 tasks
@suyanhanx suyanhanx changed the title feat(services): add SqliteConfig feat(services/sqlite): add SqliteConfig Nov 7, 2023
@hoslo hoslo mentioned this pull request Nov 7, 2023
Merged
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
@hoslo hoslo deleted the config-refactor-sqlite branch November 27, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoslo @Xuanwo @suyanhanx