Skip to content

docs(bindings/java): add basic usage in README#3534

Merged
tisonkun merged 6 commits intoapache:mainfrom
caicancai:example
Nov 12, 2023
Merged

docs(bindings/java): add basic usage in README#3534
tisonkun merged 6 commits intoapache:mainfrom
caicancai:example

Conversation

@caicancai
Copy link
Copy Markdown
Member

@caicancai caicancai commented Nov 8, 2023

close #3522

test success

@caicancai caicancai requested a review from tisonkun as a code owner November 8, 2023 12:40
@github-actions github-actions Bot added the releases-note/docs The PR modifies docs related content or has a title that begins with "docs" label Nov 8, 2023
Copy link
Copy Markdown
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect if we should add such an example. But if it's well-written, that can be fine.

Comment thread bindings/java/README.md Outdated
@caicancai
Copy link
Copy Markdown
Member Author

Do you want me to put this example in java test as a basic test

@tisonkun
Copy link
Copy Markdown
Member

tisonkun commented Nov 9, 2023

Do you want me to put this example in java test as a basic test

No. Our tests have coverage already.

Such an example can either serve in:

@caicancai
Copy link
Copy Markdown
Member Author

Do you want me to put this example in java test as a basic test

No. Our tests have coverage already.

Such an example can either serve in:

Thank you for your reply, on https://github.com/apache/incubator-opendal/tree/main/examples, it seems, are still need some other documents, is needed in my pr supplement or the next pr

@caicancai
Copy link
Copy Markdown
Member Author

@tisonkun hi, could you please help review this pr if you have time? At present, I plan to simply add an example in the readme

@caicancai caicancai requested a review from tisonkun November 12, 2023 13:21
Comment thread bindings/java/README.md
@tisonkun tisonkun changed the title docs: Binding Java should add a basic usage in binding's README docs(bindings/java): add basic usage in README Nov 12, 2023
@tisonkun tisonkun merged commit faa574f into apache:main Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/docs The PR modifies docs related content or has a title that begins with "docs"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Binding Java should add a basic usage in binding's README

2 participants