Skip to content

refactor(service/etcd): Add EtcdConfig to implement ConfigDeserializer#3543

Merged
Xuanwo merged 6 commits intoapache:mainfrom
Xuxiaotuan:main
Nov 9, 2023
Merged

refactor(service/etcd): Add EtcdConfig to implement ConfigDeserializer#3543
Xuanwo merged 6 commits intoapache:mainfrom
Xuxiaotuan:main

Conversation

@Xuxiaotuan
Copy link
Copy Markdown
Contributor

Part of #3240

@Xuxiaotuan Xuxiaotuan requested a review from Xuanwo as a code owner November 8, 2023 17:20
@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Nov 8, 2023
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, thanks!

Comment thread core/src/services/etcd/backend.rs Outdated
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 60b4d3a into apache:main Nov 9, 2023
@Xuanwo Xuanwo mentioned this pull request Nov 9, 2023
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants