Skip to content

chore(service/tikv): rename Backend to TikvBackend#3545

Merged
Xuanwo merged 4 commits intoapache:mainfrom
caicancai:fix
Nov 9, 2023
Merged

chore(service/tikv): rename Backend to TikvBackend#3545
Xuanwo merged 4 commits intoapache:mainfrom
caicancai:fix

Conversation

@caicancai
Copy link
Copy Markdown
Member

@caicancai caicancai commented Nov 9, 2023

I'm sorry, there were some regulations that weren't aware of
fix: #3512

@caicancai caicancai requested a review from Xuanwo as a code owner November 9, 2023 02:11
@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Nov 9, 2023
@caicancai caicancai marked this pull request as draft November 9, 2023 02:14
@caicancai caicancai closed this Nov 9, 2023
@caicancai caicancai deleted the fix branch November 9, 2023 02:21
Comment thread core/src/services/redis/backend.rs Outdated
@caicancai caicancai restored the fix branch November 9, 2023 02:25
@caicancai caicancai reopened this Nov 9, 2023
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 9, 2023

Hi, please use a meaningful name as your PR title.

@caicancai caicancai changed the title refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer refactor(service/tikv): rename Backend to TikvBackend Nov 9, 2023
@caicancai
Copy link
Copy Markdown
Member Author

caicancai commented Nov 9, 2023

Hi, please use a meaningful name as your PR title.

ok. Thank you for reminding me

@caicancai caicancai marked this pull request as ready for review November 9, 2023 05:55
@Xuanwo Xuanwo changed the title refactor(service/tikv): rename Backend to TikvBackend chore(service/tikv): rename Backend to TikvBackend Nov 9, 2023
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions Bot added the releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell label Nov 9, 2023
@Xuanwo Xuanwo merged commit 540cc68 into apache:main Nov 9, 2023
qingwen220 pushed a commit to qingwen220/incubator-opendal that referenced this pull request Nov 15, 2023
* refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer

* refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer

* refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer
qingwen220 pushed a commit to qingwen220/incubator-opendal that referenced this pull request Nov 15, 2023
* refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer

* refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer

* refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants