Skip to content

refactor(services/azblob): add AzblobConfig#3553

Merged
Xuanwo merged 3 commits intoapache:mainfrom
acehinnnqru:feat/azblob-config-refactor
Nov 11, 2023
Merged

refactor(services/azblob): add AzblobConfig#3553
Xuanwo merged 3 commits intoapache:mainfrom
acehinnnqru:feat/azblob-config-refactor

Conversation

@acehinnnqru
Copy link
Copy Markdown
Contributor

Impl Azblob support for #3240 .

@acehinnnqru acehinnnqru requested a review from Xuanwo as a code owner November 10, 2023 02:05
@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Nov 10, 2023
@acehinnnqru acehinnnqru force-pushed the feat/azblob-config-refactor branch from 6c88f62 to 81a3155 Compare November 10, 2023 02:06
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also implement from_map based on AzblobConfig

Comment thread core/src/services/azblob/backend.rs
Comment thread core/src/services/azblob/backend.rs Outdated
@acehinnnqru acehinnnqru force-pushed the feat/azblob-config-refactor branch from 9f3e59d to d6e249d Compare November 11, 2023 07:12
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 5dfc3c2 into apache:main Nov 11, 2023
@suyanhanx suyanhanx mentioned this pull request Dec 22, 2023
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants