Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
requested review from
PsiACE,
messense,
silver-ymz,
suyanhanx,
tisonkun and
xyjixyjixyji
as code owners
github-actions
Bot
added
the
releases-note/feat
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
xyjixyjixyji
approved these changes
Nov 10, 2023
Contributor
xyjixyjixyji
left a comment
xyjixyjixyji
left a comment
There was a problem hiding this comment.
So far LGTM, a very good API change to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements RFC-3526: List Recursive
In the future, we should eliminate
list_without_recursiveby ensuring every service supports listing the current directory. However, as this is a significant change that could affect many services, I suggest addressing it in a separate PR.