Skip to content

feat(service): alluxio support write#3566

Merged
Xuanwo merged 1 commit intoapache:mainfrom
hoslo:alluxio-support-write
Nov 14, 2023
Merged

feat(service): alluxio support write#3566
Xuanwo merged 1 commit intoapache:mainfrom
hoslo:alluxio-support-write

Conversation

@hoslo
Copy link
Copy Markdown
Contributor

@hoslo hoslo commented Nov 12, 2023

feat #3548

@hoslo hoslo requested a review from Xuanwo as a code owner November 12, 2023 06:45
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Nov 12, 2023
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 12, 2023

Hi, how about adding test first so that we can test our changes on solid base instead?

@hoslo
Copy link
Copy Markdown
Contributor Author

hoslo commented Nov 12, 2023

Hi, how about adding test first so that we can test our changes on solid base instead?

of course, Where should I start?

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 12, 2023

of course, Where should I start?

You can take #3493 as reference. Basicly, we need to add a docker-compose file to allow developers to setup test env, and than, we need to add this setup in CI workflow.

@hoslo
Copy link
Copy Markdown
Contributor Author

hoslo commented Nov 12, 2023

of course, Where should I start?

You can take #3493 as reference. Basicly, we need to add a docker-compose file to allow developers to setup test env, and than, we need to add this setup in CI workflow.

Should I add it in this pr or another?

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 12, 2023

Should I add it in this pr or another?

We can start a new PR for this and return to this PR later.

@hoslo
Copy link
Copy Markdown
Contributor Author

hoslo commented Nov 14, 2023

Should I add it in this pr or another?

We can start a new PR for this and return to this PR later.

can you review this pr?

Comment thread core/src/services/alluxio/backend.rs
Comment thread core/src/services/alluxio/writer.rs Outdated
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@Xuanwo Xuanwo merged commit b908c66 into apache:main Nov 14, 2023
@hoslo hoslo deleted the alluxio-support-write branch November 27, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants