chore: Add cpp binding Google style clang-format && format the code#3581
Merged
Xuanwo merged 1 commit intoapache:mainfrom Nov 14, 2023
Merged
chore: Add cpp binding Google style clang-format && format the code#3581Xuanwo merged 1 commit intoapache:mainfrom
Xuanwo merged 1 commit intoapache:mainfrom
Conversation
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
Xuanwo
reviewed
Nov 14, 2023
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Pleae also update CMake for code format job
Xuanwo
changed the title
github-actions
Bot
added
the
releases-note/chore
Member
|
Hi, @silver-ymz, would you like to take a review? |
Xuanwo
reviewed
Nov 14, 2023
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
I don't like git pre-commit. It's ok for me to merge this PR as is if @silver-ymz is ok with the Google Code Style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cpp binding Google style clang-format && format the code