Skip to content

refactor(core): Rename all Page to List#3589

Merged
Xuanwo merged 5 commits intomainfrom
refactor-list
Nov 14, 2023
Merged

refactor(core): Rename all Page to List#3589
Xuanwo merged 5 commits intomainfrom
refactor-list

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Nov 14, 2023

Part of #3236

This PR just change the naming and not touch the API semantic.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Nov 14, 2023
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Nov 14, 2023

TiKV test failed for it's mirror issues, not related to this PR.

Copy link
Copy Markdown
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Waiting for ci green...

Comment thread core/src/docs/upgrade.md
Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Copy Markdown
Contributor

@ClSlaid ClSlaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo Xuanwo merged commit c2040ff into main Nov 14, 2023
@Xuanwo Xuanwo deleted the refactor-list branch November 14, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants