Skip to content

feat(service): support b2#3604

Merged
Xuanwo merged 1 commit intoapache:mainfrom
hoslo:support-b2
Nov 21, 2023
Merged

feat(service): support b2#3604
Xuanwo merged 1 commit intoapache:mainfrom
hoslo:support-b2

Conversation

@hoslo
Copy link
Copy Markdown
Contributor

@hoslo hoslo commented Nov 17, 2023

Part #3585

@hoslo hoslo requested review from PsiACE and Xuanwo as code owners November 17, 2023 07:28
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Nov 17, 2023
@hoslo
Copy link
Copy Markdown
Contributor Author

hoslo commented Nov 17, 2023

I've already run the tests locally

Comment thread core/src/services/b2/backend.rs Outdated
Comment thread core/src/services/b2/backend.rs Outdated
Comment thread core/src/services/b2/backend.rs
Comment thread core/src/services/b2/backend.rs Outdated
Comment thread core/src/services/b2/backend.rs Outdated
Comment thread core/src/services/b2/backend.rs
Comment thread core/src/services/b2/backend.rs Outdated
Comment thread core/src/services/b2/core.rs Outdated
Comment thread core/src/services/b2/writer.rs Outdated
Comment thread core/src/services/b2/writer.rs Outdated
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, great work!

Comment thread core/src/services/b2/backend.rs
Comment thread core/src/services/b2/backend.rs Outdated
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, only some small typo. We are nearly good to go!

Comment thread .env.example Outdated
Comment thread Cargo.lock Outdated
Comment thread core/src/services/b2/writer.rs Outdated
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's go!

@Xuanwo Xuanwo merged commit 26b52cc into apache:main Nov 21, 2023
@hoslo hoslo deleted the support-b2 branch November 27, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants