Skip to content

feat(bindings/nodejs): read/write stream#3619

Merged
Xuanwo merged 1 commit intomainfrom
nodejs-stream
Nov 27, 2023
Merged

feat(bindings/nodejs): read/write stream#3619
Xuanwo merged 1 commit intomainfrom
nodejs-stream

Conversation

@suyanhanx
Copy link
Copy Markdown
Member

@suyanhanx suyanhanx commented Nov 18, 2023 •
edited
Loading

This PR introduces the reader and writer, and readable/writable stream based on them.

@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Nov 18, 2023
@suyanhanx
Copy link
Copy Markdown
Member Author

suyanhanx commented Nov 18, 2023

Are too many irrelevant tests being started?

@suyanhanx
Copy link
Copy Markdown
Member Author

suyanhanx commented Nov 18, 2023

Need to add capability detect.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 20, 2023

Seems we need to add capability support first?

@suyanhanx
Copy link
Copy Markdown
Member Author

suyanhanx commented Nov 20, 2023

Seems we need to add capability support first?

Yes. I'm going to add it first.

@suyanhanx suyanhanx changed the title feat(bindings/nodejs): read/write stream feat(bindings/nodejs): write stream Nov 20, 2023
@suyanhanx suyanhanx marked this pull request as ready for review November 24, 2023 08:03
Xuanwo
Xuanwo reviewed Nov 24, 2023
View reviewed changes
Comment thread bindings/nodejs/tests/fixtures/random Outdated
Comment thread bindings/nodejs/tests/suites/async.suite.mjs Outdated
@suyanhanx suyanhanx changed the title feat(bindings/nodejs): write stream feat(bindings/nodejs): read/write stream Nov 26, 2023
@suyanhanx
Copy link
Copy Markdown
Member Author

suyanhanx commented Nov 26, 2023

Invite @everpcpc to take a look.

@everpcpc
Copy link
Copy Markdown
Contributor

everpcpc commented Nov 26, 2023

lgtm, thanks!

@suyanhanx suyanhanx requested a review from Xuanwo November 27, 2023 05:40
@suyanhanx suyanhanx mentioned this pull request Nov 27, 2023
Closed
18 tasks
Xuanwo
Xuanwo reviewed Nov 27, 2023
View reviewed changes
Comment thread bindings/nodejs/index.js Outdated
Comment thread bindings/nodejs/tests/utils.mjs Outdated
Xuanwo
Xuanwo reviewed Nov 27, 2023
View reviewed changes
Comment thread bindings/nodejs/index.js
Comment thread bindings/nodejs/index.js Outdated
@suyanhanx suyanhanx marked this pull request as draft November 27, 2023 11:40
@suyanhanx
feat(bindings/nodejs): read/write stream
ffedefe 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx marked this pull request as ready for review November 27, 2023 12:04
@suyanhanx suyanhanx requested a review from Xuanwo November 27, 2023 12:06
Xuanwo
Xuanwo approved these changes Nov 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit 049ce8d into main Nov 27, 2023
@Xuanwo Xuanwo deleted the nodejs-stream branch November 27, 2023 12:49
@G-XD G-XD mentioned this pull request Nov 27, 2023
Merged
@Xuanwo Xuanwo mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suyanhanx @Xuanwo @everpcpc