refactor(bindings/java): Use AllArgsConstructor to simplify Entry and Capability#3628
Closed
mdxabu wants to merge 1 commit intoapache:mainfrom
mdxabu:test_java
Closed
refactor(bindings/java): Use AllArgsConstructor to simplify Entry and Capability#3628mdxabu wants to merge 1 commit intoapache:mainfrom mdxabu:test_java
mdxabu wants to merge 1 commit intoapache:mainfrom
mdxabu:test_java
Conversation
Member
|
Hi, thanks for contributing! Please address the CI failure first: Error: Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.39.0:check (default-cli) on project opendal-java: The following files had format violations:
Error: src/main/java/org/apache/opendal/Entry.java
Error: @@ -27,5 +27,4 @@
Error: public·class·Entry·{
Error: ····public·final·String·path;
Error: ····public·final·Metadata·metadata;
Error: -
Error: }
Error: src/main/java/org/apache/opendal/Capability.java
Error: @@ -218,5 +218,4 @@
Error: ·····*·If·operator·supports·blocking.
Error: ·····*/
Error: ····public·final·boolean·blocking;
Error: -
Error: }
Error: Run 'mvn spotless:apply' to fix these violations.
Error: -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging. |
tisonkun
requested changes
Nov 20, 2023
Member
There was a problem hiding this comment.
This is a discussed and rejected flavor - #3154 (comment)
Unless you have a convincing reason to change the conclusion linked above, I'm going to close this PR in days.
Author
Oh ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Maintainers,
I have made improvements to
Entry.javaandCapability.java. The getter and setter methods have been organized using Lombok. Please review these changes and merge this PR.👆 This annotation will create all argument constructor.
Best,
F.Mohamed Abdullah