Skip to content

refactor(bindings/java): Use AllArgsConstructor to simplify Entry and Capability#3628

Closed
mdxabu wants to merge 1 commit intoapache:mainfrom
mdxabu:test_java
Closed

refactor(bindings/java): Use AllArgsConstructor to simplify Entry and Capability#3628
mdxabu wants to merge 1 commit intoapache:mainfrom
mdxabu:test_java

Conversation

@mdxabu
Copy link
Copy Markdown

@mdxabu mdxabu commented Nov 20, 2023

Hello Maintainers,

I have made improvements to Entry.java and Capability.java. The getter and setter methods have been organized using Lombok. Please review these changes and merge this PR.

@AllArgsConstructor

👆 This annotation will create all argument constructor.

Best,
F.Mohamed Abdullah

@mdxabu mdxabu requested a review from tisonkun as a code owner November 20, 2023 12:03
@Xuanwo Xuanwo requested a review from G-XD November 20, 2023 12:17
@Xuanwo Xuanwo changed the title Feature(Entry.java & Capability.java) refactor(bindings/java): Use AllArgsConstructor to simplify Entry and Capability Nov 20, 2023
@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Nov 20, 2023
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 20, 2023

Hi, thanks for contributing! Please address the CI failure first:

Error:  Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.39.0:check (default-cli) on project opendal-java: The following files had format violations:
Error:      src/main/java/org/apache/opendal/Entry.java
Error:          @@ -27,5 +27,4 @@
Error:           public·class·Entry·{
Error:           ····public·final·String·path;
Error:           ····public·final·Metadata·metadata;
Error:          -
Error:           }
Error:      src/main/java/org/apache/opendal/Capability.java
Error:          @@ -218,5 +218,4 @@
Error:           ·····*·If·operator·supports·blocking.
Error:           ·····*/
Error:           ····public·final·boolean·blocking;
Error:          -
Error:           }
Error:  Run 'mvn spotless:apply' to fix these violations.
Error:  -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.

Copy link
Copy Markdown
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a discussed and rejected flavor - #3154 (comment)

Unless you have a convincing reason to change the conclusion linked above, I'm going to close this PR in days.

@mdxabu
Copy link
Copy Markdown
Author

mdxabu commented Nov 20, 2023

This is a discussed and rejected flavor - #3154 (comment)

Unless you have a convincing reason to change the conclusion linked above, I'm going to close this PR in days.

Oh ok

@mdxabu mdxabu closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants