Skip to content

ci(services/etcd): Use ALLOW_NONE_AUTHENTICATION as workaround#3638

Merged
Xuanwo merged 4 commits intomainfrom
fix-etcd
Nov 21, 2023
Merged

ci(services/etcd): Use ALLOW_NONE_AUTHENTICATION as workaround#3638
Xuanwo merged 4 commits intomainfrom
fix-etcd

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Nov 21, 2023

No description provided.

@Xuanwo
ci: Fix etcd with tls and auth failed to start
482ca15 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
ci(services/etcd): Use ALLOW_NONE_AUTHENTICATION as workaround
0b365ea 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from PsiACE as a code owner November 21, 2023 06:07
@github-actions github-actions Bot added the releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" label Nov 21, 2023
@Xuanwo Xuanwo requested a review from G-XD November 21, 2023 06:07
@Xuanwo Xuanwo mentioned this pull request Nov 21, 2023
Closed
@G-XD
Copy link
Copy Markdown
Contributor

G-XD commented Nov 21, 2023

https://github.com/apache/incubator-opendal/blob/d09c9c921d946d5a96b22bf73e9a35e5d7c8cc83/.github/services/etcd/etcd-tls/action.yml#L40-L41

Should the OPENDAL_ETCD_USERNAME and OPENDAL_ETCD_PASSWORD be deleted?

@Xuanwo
Remove user & passname
f0fe81d 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Nov 21, 2023

https://github.com/apache/incubator-opendal/blob/d09c9c921d946d5a96b22bf73e9a35e5d7c8cc83/.github/services/etcd/etcd-tls/action.yml#L40-L41

Should the OPENDAL_ETCD_USERNAME and OPENDAL_ETCD_PASSWORD be deleted?

Yes! But I don't know why it still passes..

@G-XD
Copy link
Copy Markdown
Contributor

G-XD commented Nov 21, 2023

LGTM

@Xuanwo Xuanwo merged commit 2ce981d into main Nov 21, 2023
@Xuanwo Xuanwo deleted the fix-etcd branch November 21, 2023 07:10
@G-XD G-XD mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PsiACE PsiACE PsiACE approved these changes

@G-XD G-XD Awaiting requested review from G-XD

Assignees

No one assigned

Labels

releases-note/ci The PR modifies CI-related content or has a title that begins with "ci"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Xuanwo @G-XD @PsiACE