Skip to content

ci: dry run publish on rc tags for python binding#3645

Merged
Xuanwo merged 1 commit intoapache:mainfrom
everpcpc:fix-dryrun
Nov 22, 2023
Merged

ci: dry run publish on rc tags for python binding#3645
Xuanwo merged 1 commit intoapache:mainfrom
everpcpc:fix-dryrun

Conversation

@everpcpc
Copy link
Copy Markdown
Contributor

@everpcpc everpcpc commented Nov 22, 2023

pypa/gh-action-pypi-publish dose not have a dryrun option, so we just list package files.

cc @suyanhanx

@github-actions github-actions Bot added the releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" label Nov 22, 2023
@everpcpc everpcpc changed the title ci: dry run on rc tags for python & nodejs binding ci: dry run publish on rc tags for python & nodejs binding Nov 22, 2023
@suyanhanx
Copy link
Copy Markdown
Member

suyanhanx commented Nov 22, 2023

Thans for your work! But I'm sorry. I'm working on the nodejs part in #3632. Could you please remove them?

@everpcpc everpcpc changed the title ci: dry run publish on rc tags for python & nodejs binding ci: dry run publish on rc tags for python binding Nov 22, 2023
@suyanhanx
Copy link
Copy Markdown
Member

Maybe we could try to publish python bindng to here https://test.pypi.org/ as dry run?

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Xuanwo Xuanwo merged commit 0b3505b into apache:main Nov 22, 2023
@everpcpc everpcpc deleted the fix-dryrun branch November 22, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/ci The PR modifies CI-related content or has a title that begins with "ci"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants