Skip to content

ci: Add java linux arm64 build#3660

Merged
Xuanwo merged 4 commits intomainfrom
fix-java-arm64-build
Nov 24, 2023
Merged

ci: Add java linux arm64 build#3660
Xuanwo merged 4 commits intomainfrom
fix-java-arm64-build

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Nov 24, 2023 •
edited
Loading

@github-actions github-actions Bot added the releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" label Nov 24, 2023
tisonkun
tisonkun reviewed Nov 24, 2023
View reviewed changes
Comment thread .github/workflows/release_java.yml Outdated
tisonkun
tisonkun reviewed Nov 24, 2023
View reviewed changes
Comment thread bindings/dotnet/build.py Outdated
tisonkun
tisonkun reviewed Nov 24, 2023
View reviewed changes
Comment thread bindings/java/Cargo.toml Outdated
tisonkun
tisonkun reviewed Nov 24, 2023
View reviewed changes
Comment thread bindings/java/tools/build.py Outdated
tisonkun
tisonkun reviewed Nov 24, 2023
View reviewed changes
Comment thread bindings/python/tests/test_sync_delete.py Outdated
tisonkun
tisonkun reviewed Nov 24, 2023
View reviewed changes
Comment thread core/Cargo.toml
@Xuanwo
Fix java on arm64
9c46578 
Signed-off-by: Xuanwo <github@xuanwo.io>
tisonkun
tisonkun reviewed Nov 24, 2023
View reviewed changes
Comment thread scripts/merge_local_staging.py
@Xuanwo Xuanwo force-pushed the fix-java-arm64-build branch from aa9c82b to 9c46578 Compare November 24, 2023 02:24
tisonkun
tisonkun reviewed Nov 24, 2023
View reviewed changes
Comment thread scripts/merge_local_staging.py
tisonkun
tisonkun approved these changes Nov 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - as long as CI can cross compile 😆

@Xuanwo
use env instead
f6c6ad4 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Nov 24, 2023 •
edited
Loading

Please don't merge. I will merge this by myself after build passed.

@Xuanwo
Disable tikv-tls test for temp
59b93fc 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
revert workflow changes
e463387 
Signed-off-by: Xuanwo <github@xuanwo.io>
messense
messense reviewed Nov 24, 2023
View reviewed changes
Comment thread .github/workflows/release_java.yml
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Nov 24, 2023

This PR is meaningful even it doesn't work on glibc 2.26: we now have arm64 build support. We can address glibc issues in next PR.

cc @tisonkun @messense, how about merging this PR as-is?

messense
messense approved these changes Nov 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with merging it as-is, we can resolve the glibc version issue in another PR.

@Xuanwo Xuanwo mentioned this pull request Nov 24, 2023
Closed
@Xuanwo Xuanwo merged commit 787fd39 into main Nov 24, 2023
@Xuanwo Xuanwo deleted the fix-java-arm64-build branch November 24, 2023 04:39
@G-XD G-XD mentioned this pull request Nov 27, 2023
Merged
@Xuanwo Xuanwo mentioned this pull request Dec 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@messense messense messense approved these changes

@tisonkun tisonkun tisonkun approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@Zheaoli Zheaoli Awaiting requested review from Zheaoli

Assignees

No one assigned

Labels

releases-note/ci The PR modifies CI-related content or has a title that begins with "ci"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: bindings/java linux/arm .jar

3 participants

@Xuanwo @messense @tisonkun