Skip to content

fix(core): Path in remove not normalized#3671

Merged
Xuanwo merged 2 commits intomainfrom
fix-remove
Nov 27, 2023
Merged

fix(core): Path in remove not normalized#3671
Xuanwo merged 2 commits intomainfrom
fix-remove

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Nov 27, 2023

Fix #3669

@Xuanwo
fix(core): Path in remove not normalized
b2dd437 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from suyanhanx November 27, 2023 13:15
@github-actions github-actions Bot added the releases-note/fix The PR fixes a bug or has a title that begins with "fix" label Nov 27, 2023
@suyanhanx
Copy link
Copy Markdown
Member

suyanhanx commented Nov 27, 2023

Do we need to update test cases?

@Xuanwo
Fix tests
4249778 
Signed-off-by: Xuanwo <github@xuanwo.io>
suyanhanx
suyanhanx approved these changes Nov 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo Xuanwo merged commit d789892 into main Nov 27, 2023
@Xuanwo Xuanwo deleted the fix-remove branch November 27, 2023 14:09
@G-XD G-XD mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

Assignees

No one assigned

Labels

releases-note/fix The PR fixes a bug or has a title that begins with "fix"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

core: remove should normalize file path

2 participants

@Xuanwo @suyanhanx