Skip to content

fix(core): Build with redis features and Rust < 1.72#3683

Merged
Xuanwo merged 1 commit intoapache:mainfrom
vincentdephily:fix_redis_build
Nov 30, 2023
Merged

fix(core): Build with redis features and Rust < 1.72#3683
Xuanwo merged 1 commit intoapache:mainfrom
vincentdephily:fix_redis_build

Conversation

@vincentdephily
Copy link
Copy Markdown
Contributor

Just need to be explicit about using our own redis mod rather than the redis crate.

Fixes #3595

Just need to be explicit about using our own redis mod rather than the redis crate.

Fixes apache#3595
@github-actions github-actions Bot added the releases-note/fix The PR fixes a bug or has a title that begins with "fix" label Nov 29, 2023
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 10cc031 into apache:main Nov 30, 2023
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 30, 2023

Hi, @G-XD, sorry for my fault this not include the fix for this issue in advance. Can you start a new round of VOTE that include this fix? Sccache (mozilla/sccache#1992) is waiting for this.

@vincentdephily vincentdephily deleted the fix_redis_build branch November 30, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/fix The PR fixes a bug or has a title that begins with "fix"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenDAL v0.42 with service-redis enable will produce an hard error

2 participants